fix: treat firebase.json as root dir for Firebase resources
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthegedus
changed the title
firebase.json as root dir for Firebase resources
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2021
## [0.6.2](v0.6.1...v0.6.2) (2021-05-07) ### Bug Fixes * treat `firebase.json` as root dir for Firebase resources ([#43](#43)) ([82c8493](82c8493))
|
🎉 This PR is included in version 0.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dirs created by the adapter are expected to be relative to the
firebase.jsonfile, it is the root location. Currently this is not the case as noted in #33To resolve this we must:
firebase.jsondir as the rootfirebase.json.hosting.publicdir relative to this new rootfirebase.json.functions.sourcedir relative to this new rootcloudRunBuildDirdir relative to this new rootFixes: #33